complete 2.5 with qa tests

tests/Feature/Admin/CompanyClientTest.php

@@ -4,10 +4,12 @@ use App\Enums\UserStatus;
 use App\Enums\UserType;
 use App\Models\AdminLog;
 use App\Models\User;
+use Illuminate\Support\Facades\Notification;
 use Livewire\Volt\Volt;
 
 beforeEach(function () {
     $this->admin = User::factory()->admin()->create();
+    Notification::fake();
 });
 
 // ===========================================

tests/Feature/Admin/IndividualClientTest.php

@@ -4,10 +4,12 @@ use App\Enums\UserStatus;
 use App\Enums\UserType;
 use App\Models\AdminLog;
 use App\Models\User;
+use Illuminate\Support\Facades\Notification;
 use Livewire\Volt\Volt;
 
 beforeEach(function () {
     $this->admin = User::factory()->admin()->create();
+    Notification::fake();
 });
 
 // ===========================================

tests/Feature/Admin/WelcomeEmailTest.php

@@ -0,0 +1,269 @@
+<?php
+
+use App\Models\User;
+use App\Notifications\WelcomeAccountNotification;
+use Illuminate\Support\Facades\Notification;
+use Livewire\Volt\Volt;
+
+beforeEach(function () {
+    $this->admin = User::factory()->admin()->create();
+});
+
+// ===========================================
+// Individual Client Welcome Email Tests
+// ===========================================
+
+test('welcome email is queued when creating individual client', function () {
+    Notification::fake();
+
+    $this->actingAs($this->admin);
+
+    Volt::test('admin.clients.individual.create')
+        ->set('full_name', 'Test Client')
+        ->set('email', 'testclient@example.com')
+        ->set('national_id', '123456789')
+        ->set('phone', '+970599123456')
+        ->set('password', 'password123')
+        ->set('preferred_language', 'ar')
+        ->call('create')
+        ->assertHasNoErrors();
+
+    $client = User::where('email', 'testclient@example.com')->first();
+
+    Notification::assertSentTo(
+        $client,
+        WelcomeAccountNotification::class,
+        function ($notification) {
+            return $notification->password === 'password123';
+        }
+    );
+});
+
+test('welcome email contains correct password for individual client', function () {
+    Notification::fake();
+
+    $this->actingAs($this->admin);
+
+    Volt::test('admin.clients.individual.create')
+        ->set('full_name', 'Test Client')
+        ->set('email', 'testclient@example.com')
+        ->set('national_id', '123456789')
+        ->set('phone', '+970599123456')
+        ->set('password', 'securePassword456')
+        ->set('preferred_language', 'en')
+        ->call('create')
+        ->assertHasNoErrors();
+
+    $client = User::where('email', 'testclient@example.com')->first();
+
+    Notification::assertSentTo(
+        $client,
+        WelcomeAccountNotification::class,
+        function ($notification) {
+            return $notification->password === 'securePassword456';
+        }
+    );
+});
+
+// ===========================================
+// Company Client Welcome Email Tests
+// ===========================================
+
+test('welcome email is queued when creating company client', function () {
+    Notification::fake();
+
+    $this->actingAs($this->admin);
+
+    Volt::test('admin.clients.company.create')
+        ->set('company_name', 'Test Company Ltd')
+        ->set('company_cert_number', 'COMP123456')
+        ->set('contact_person_name', 'John Doe')
+        ->set('contact_person_id', '987654321')
+        ->set('email', 'company@example.com')
+        ->set('phone', '+970599123456')
+        ->set('password', 'companyPass123')
+        ->set('preferred_language', 'ar')
+        ->call('create')
+        ->assertHasNoErrors();
+
+    $client = User::where('email', 'company@example.com')->first();
+
+    Notification::assertSentTo(
+        $client,
+        WelcomeAccountNotification::class,
+        function ($notification) {
+            return $notification->password === 'companyPass123';
+        }
+    );
+});
+
+test('welcome email contains correct password for company client', function () {
+    Notification::fake();
+
+    $this->actingAs($this->admin);
+
+    Volt::test('admin.clients.company.create')
+        ->set('company_name', 'Another Company')
+        ->set('company_cert_number', 'COMP789012')
+        ->set('contact_person_name', 'Jane Smith')
+        ->set('contact_person_id', '111222333')
+        ->set('email', 'another@example.com')
+        ->set('phone', '+970599999999')
+        ->set('password', 'anotherSecure789')
+        ->set('preferred_language', 'en')
+        ->call('create')
+        ->assertHasNoErrors();
+
+    $client = User::where('email', 'another@example.com')->first();
+
+    Notification::assertSentTo(
+        $client,
+        WelcomeAccountNotification::class,
+        function ($notification) {
+            return $notification->password === 'anotherSecure789';
+        }
+    );
+});
+
+// ===========================================
+// Language Support Tests
+// ===========================================
+
+test('welcome email uses arabic subject for arabic preference', function () {
+    $user = User::factory()->individual()->create(['preferred_language' => 'ar']);
+    $notification = new WelcomeAccountNotification('password123');
+
+    $mailMessage = $notification->toMail($user);
+
+    expect($mailMessage->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
+});
+
+test('welcome email uses english subject for english preference', function () {
+    $user = User::factory()->individual()->create(['preferred_language' => 'en']);
+    $notification = new WelcomeAccountNotification('password123');
+
+    $mailMessage = $notification->toMail($user);
+
+    expect($mailMessage->subject)->toBe('Welcome to Libra Law Firm');
+});
+
+test('welcome email defaults to arabic when notification receives user without language', function () {
+    $user = User::factory()->individual()->create(['preferred_language' => 'ar']);
+
+    // Simulate a scenario where preferred_language could be missing
+    // by creating a mock object that returns null for preferred_language
+    $mockUser = new class($user)
+    {
+        public $preferred_language = null;
+
+        private $user;
+
+        public function __construct($user)
+        {
+            $this->user = $user;
+        }
+
+        public function __get($name)
+        {
+            if ($name === 'preferred_language') {
+                return null;
+            }
+
+            return $this->user->$name;
+        }
+    };
+
+    $notification = new WelcomeAccountNotification('password123');
+    $mailMessage = $notification->toMail($mockUser);
+
+    expect($mailMessage->subject)->toBe('مرحباً بك في مكتب ليبرا للمحاماة');
+});
+
+// ===========================================
+// Email Content Tests
+// ===========================================
+
+test('welcome email passes correct data to view', function () {
+    $user = User::factory()->individual()->create([
+        'full_name' => 'Test User',
+        'email' => 'test@example.com',
+        'preferred_language' => 'en',
+    ]);
+
+    $notification = new WelcomeAccountNotification('testPassword123');
+    $mailMessage = $notification->toMail($user);
+
+    expect($mailMessage->viewData['user']->id)->toBe($user->id);
+    expect($mailMessage->viewData['password'])->toBe('testPassword123');
+    expect($mailMessage->viewData['locale'])->toBe('en');
+});
+
+test('welcome email passes company name for company clients', function () {
+    $user = User::factory()->company()->create([
+        'company_name' => 'Test Company Ltd',
+        'preferred_language' => 'ar',
+    ]);
+
+    $notification = new WelcomeAccountNotification('companyPass');
+    $mailMessage = $notification->toMail($user);
+
+    expect($mailMessage->viewData['user']->company_name)->toBe('Test Company Ltd');
+    expect($mailMessage->viewData['locale'])->toBe('ar');
+});
+
+// ===========================================
+// Notification Queue Tests
+// ===========================================
+
+test('welcome notification implements should queue interface', function () {
+    $notification = new WelcomeAccountNotification('password');
+
+    expect($notification)->toBeInstanceOf(\Illuminate\Contracts\Queue\ShouldQueue::class);
+});
+
+test('welcome notification uses queueable trait', function () {
+    $traits = class_uses(WelcomeAccountNotification::class);
+
+    expect($traits)->toContain(\Illuminate\Bus\Queueable::class);
+});
+
+// ===========================================
+// Admin Exclusion Tests
+// ===========================================
+
+test('no welcome email is sent when admin creates another admin via factory', function () {
+    Notification::fake();
+
+    // Admin accounts are not created through the client forms
+    // They are created differently (not through the admin client creation flow)
+    // This test verifies that the admin factory itself doesn't trigger welcome emails
+    $admin = User::factory()->admin()->create();
+
+    // Factory creation doesn't trigger notifications automatically
+    Notification::assertNothingSent();
+});
+
+// ===========================================
+// User Creation Success Tests
+// ===========================================
+
+test('user creation succeeds even if notification would fail', function () {
+    // Use fake to prevent actual sending, which simulates the queued behavior
+    Notification::fake();
+
+    $this->actingAs($this->admin);
+
+    Volt::test('admin.clients.individual.create')
+        ->set('full_name', 'Test Client')
+        ->set('email', 'testclient@example.com')
+        ->set('national_id', '123456789')
+        ->set('phone', '+970599123456')
+        ->set('password', 'password123')
+        ->set('preferred_language', 'ar')
+        ->call('create')
+        ->assertHasNoErrors()
+        ->assertRedirect(route('admin.clients.individual.index'));
+
+    // User was created successfully
+    expect(User::where('email', 'testclient@example.com')->exists())->toBeTrue();
+});