From 7d762902a2d0fa8bca7052ee43f9bbabf3a87599 Mon Sep 17 00:00:00 2001 From: Naser Mansour Date: Mon, 28 Sep 2026 00:15:23 +0300 Subject: [PATCH] Bump Nablus workshop flyer size for readability max-h-40 (160px) was too small to read comfortably; bumped to max-h-56 (224px), between that and the original too-large 256px. Rebuilt frontend assets and confirmed the class compiled. Co-Authored-By: Claude Sonnet 5 --- docs/tasks/21.md | 68 +++++++++++++++++++ docs/tasks/statuses.md | 2 + .../pages/forms/nablus-workshop.blade.php | 2 +- 3 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 docs/tasks/21.md diff --git a/docs/tasks/21.md b/docs/tasks/21.md new file mode 100644 index 0000000..3362d2b --- /dev/null +++ b/docs/tasks/21.md @@ -0,0 +1,68 @@ +--- +id: 21 +title: 21 Nablus Workshop Form - Flyer Size Adjustment +status: Done +date: 2026-09-28 +parent: null +--- + +## Description + +Follow-up to tasks 18/19. Naser says the flyer image is now a bit too small to read comfortably +(it was capped to `max-h-40`, 160px) — he wants it bumped up to a size that's still compact but +readable. Pure styling change, no logic involved. + +**File to modify:** `resources/views/livewire/pages/forms/nablus-workshop.blade.php` + +Current flyer image markup: + +```blade + ورشة متخصصة: القانون، التسويق الرقمي، وإدارة المتاجر الإلكترونية +``` + +Change only the height cap, `max-h-40` → `max-h-56` (224px — roughly midway between the too-small +160px from task 19 and the too-large 256px from task 18). Nothing else in the class string +changes: + +```blade + class="max-h-56 w-auto mx-auto rounded-lg shadow-[0_2px_8px_rgba(0,0,0,0.1)]" +``` + +`max-h-56` is a standard Tailwind spacing-scale utility (14rem), same family as the `max-h-40`/ +`max-h-64` already used in this file's history, so it will compile the same way once the frontend +build runs (see step below — required, do not skip). + +**Required build step:** after making the edit, run `npm run build` (node/npm are only reachable +via `source ~/.nvm/nvm.sh && nvm use v24.20.0` in this environment — not on the default PATH) and +grep the freshly generated `public/build/assets/*.css` file for `max-h-56` to confirm it compiled. +Tasks 18/19 shipped a class that silently never took effect because nobody rebuilt the stale +`public/build` bundle — do not repeat that. + +## Acceptance Criteria + +- [x] The flyer `` tag's class attribute in + `resources/views/livewire/pages/forms/nablus-workshop.blade.php` contains `max-h-56` and + does not contain `max-h-40` or `max-h-64` +- [x] `npm run build` was run after the edit, and `max-h-56` is confirmed present (via grep) in + the newly generated `public/build/assets/*.css` — state the exact filename and grep result + in the completion report +- [x] Visiting `/forms/nablus-workshop` still returns HTTP 200 +- [x] The existing test suite for this page (`tests/Feature/Public/NablusWorkshopRegistrationTest.php`) + still passes unchanged + +## QA Verification (2026-09-28) + +- Class attribute confirmed: `class="max-h-56 w-auto mx-auto rounded-lg shadow-[0_2px_8px_rgba(0,0,0,0.1)]"` + — no `max-h-40`/`max-h-64` present. +- Grepped current `public/build/assets/app-XIQ2Iam8.css` fresh (not trusting the report's + filename) — file confirmed still present with that name, `max-h-56` found in it. +- `curl http://127.0.0.1:8971/forms/nablus-workshop` → HTTP 200. +- `php artisan test tests/Feature/Public/NablusWorkshopRegistrationTest.php` → 7 passed (26 assertions). + +## Sub-tasks + +None. diff --git a/docs/tasks/statuses.md b/docs/tasks/statuses.md index 272999c..a0a90b8 100644 --- a/docs/tasks/statuses.md +++ b/docs/tasks/statuses.md @@ -4,6 +4,7 @@ **Last synced:** 2026-09-27 — 17-2 QA passed (7/7 tests), parent 17 Done; full-suite regression gate: 1723 passed / 69 pre-existing unrelated failures **Last synced:** 2026-09-28 — 19 QA passed (logo removed, flyer max-h-40 confirmed, 7/7 tests), Done **Last synced:** 2026-09-28 — 20 QA passed (auth-pattern/bg-background/card/text-body confirmed in compiled CSS and Blade, 7/7 tests), Done +**Last synced:** 2026-09-28 — 21 QA passed (flyer max-h-56 confirmed in Blade and compiled CSS, HTTP 200, 7/7 tests), Done | ID | Title | Status | |----|-------|--------| @@ -131,3 +132,4 @@ | 18 | 18 Nablus Workshop Form - Image Sizing Fix | Done | | 19 | 19 Nablus Workshop Form - Remove Logo, Shrink Flyer Further | Done | | 20 | 20 Nablus Workshop Form - Match Site Background and Card Styling | Done | +| 21 | 21 Nablus Workshop Form - Flyer Size Adjustment | Done | diff --git a/resources/views/livewire/pages/forms/nablus-workshop.blade.php b/resources/views/livewire/pages/forms/nablus-workshop.blade.php index 6931a7a..462f9dc 100644 --- a/resources/views/livewire/pages/forms/nablus-workshop.blade.php +++ b/resources/views/livewire/pages/forms/nablus-workshop.blade.php @@ -39,7 +39,7 @@ new #[Layout('components.layouts.standalone')] class extends Component ورشة متخصصة: القانون، التسويق الرقمي، وإدارة المتاجر الإلكترونية