naser/libra
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

24-2: navigation and footer — implemented, QA Review

Browse Source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
Naser Mansour
2026-10-31 18:43:25 +02:00
parent 5f5d1d2b31
commit 8b2c35f76f
9 changed files with 303 additions and 277 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/tasks/24-2.md
+1 -1
View File
@@ -1,7 +1,7 @@
---
id: 24-2
title: 24-2 Navigation and Footer
status: Ready for Dev
status: QA Review
date: 2026-10-31
parent: 24
---
docs/tasks/manual-tests/24-2.md
+14
View File
@@ -0,0 +1,14 @@
# Manual tests — 24-2 Navigation and Footer
Automated (passed 2026-10-31, `tests/Feature/Design/PublicNavFooterTest.php`, 7 tests): sticky header markup, five links,
aria-current on /about and /posts, language pill target, Dashboard/logout for client and admin, footer four columns with
phone/email/legal links and no "Unsplash", all 18 site.* keys in ar and en, `language-toggle`, `navigation.php`, `footer.php`
untouched, `x-navigation` used only by the public layout. UI loop (libra.test `/`, 390 and 1440): no horizontal scroll.
- [ ] `/` at 1440px: nav 72px high, sticks while scrolling, brand + five links + EN pill + Client login + gold Book button; bottom border appears after scrolling a little.
- [ ] Hover a link: dashed gold underline slides in. Fail: no underline.
- [ ] At 1000px and 390px: links hidden, menu button opens a cream sheet with five links, login and Book; Escape closes it; no sideways scroll.
- [ ] Log in as a client: nav shows Dashboard and a working Log out; as admin, Dashboard opens `/admin/dashboard`.
- [ ] Click the EN / ع pill: language switches and the pill flips.
- [ ] Footer at 1440px: four columns, forest background, gold hairline on top, © year; at 390px one column.
- [ ] Known to check by eye: the Book button points to `/#book` and Services to `/#services`; those anchors exist only after 24-4/24-5.
docs/tasks/statuses.md
+1 -1
View File
@@ -138,7 +138,7 @@
| 23 | 23 Fix AdminNotificationService Carbon TypeError Masking Exceptions | Done |
| 24 | 24 Public-Site Redesign (PRD 1.4) | Ready for Dev |
| 24-1 | 24-1 Public Design Foundation (Stylesheet, Script, Fonts, Layout) | QA Review |
| 24-2 | 24-2 Navigation and Footer | Ready for Dev |
| 24-2 | 24-2 Navigation and Footer | QA Review |
| 24-3 | 24-3 Signature Balance Component | Ready for Dev |
| 24-4 | 24-4 Home Page Sections (Hero to Latest Articles) | Ready for Dev |
| 24-5 | 24-5 Home Booking Card (Compact Booking and Day Strip) | Ready for Dev |