From a8316cfc82ad45aa44da188e198c4d7f8f6fccad Mon Sep 17 00:00:00 2001 From: Naser Mansour Date: Sun, 27 Sep 2026 22:08:08 +0300 Subject: [PATCH] Reconcile pipeline docs with manual commits made outside the pipeline (Jan 2026) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Checked all 21 manual commits between abde8698 and 147231f (pre-dating today's takeover) against the newly-built docs/tasks/ and docs/ux-design.md. Two real conflicts found and fixed: - Scholarship Aspiration section (task 16-6) was built, then fully removed from /about in production (commit e8c1730, 2026-01-11) — task title and ux-design.md corrected to say REMOVED, do not re-implement. - Two-factor authentication was disabled in config/fortify.php at client request (commit f8d9133, 2026-01-17) — CLAUDE.md and ux-design.md corrected to say the 2FA code path is dormant, not live. Everything else in that range (copy edits, mail/SMTP fixes, autorefresh bug fixes, footer brand wording, php-fpm production notes already captured in CLAUDE.md) doesn't contradict anything in the pipeline docs — no edit needed. Co-Authored-By: Claude Sonnet 5 --- CLAUDE.md | 7 +++++-- docs/tasks/16-6.md | 11 +++++++++-- docs/tasks/statuses.md | 2 +- docs/ux-design.md | 10 ++++++---- 4 files changed, 21 insertions(+), 9 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index 3650593..360465a 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -123,7 +123,7 @@ Core models in `app/Models/`: /admin/* - Admin dashboard (requires admin middleware) /client/* - Client dashboard -/settings/* - User settings (profile, password, 2FA, appearance) +/settings/* - User settings (profile, password, appearance; 2FA route only registers if the feature is re-enabled, see below) ``` ### Middleware @@ -135,7 +135,10 @@ Core models in `app/Models/`: ### Authentication (Fortify) All auth is handled via Fortify with custom Volt views. Features enabled: - Email verification, Password reset, Profile/password updates -- Two-factor authentication with QR codes and recovery codes +- Two-factor authentication (QR codes + recovery codes) is **disabled in production** — commented + out in `config/fortify.php` at client request (2026-01-17). `routes/web.php` only registers + `settings/two-factor` when `Features::canManageTwoFactorAuthentication()` is true, so the code + path still exists but is currently dormant. Don't re-enable without confirming with Naser first. - Note: Public registration is disabled; admin creates all client accounts ### Volt Component Pattern diff --git a/docs/tasks/16-6.md b/docs/tasks/16-6.md index ccfd7ff..c75a67a 100644 --- a/docs/tasks/16-6.md +++ b/docs/tasks/16-6.md @@ -1,6 +1,6 @@ --- id: 16-6 -title: 16-6 Scholarship Aspiration Section +title: 16-6 Scholarship Aspiration Section (REMOVED from production 2026-01-11 — do not re-implement) status: Done date: 2026-09-27 parent: 16 @@ -8,7 +8,14 @@ parent: 16 ## Description -As a website visitor I want to learn about Libra's scholarship aspiration So that I understand their vision for supporting Palestinian arts and law students. Full implementation history: docs/stories/story-16.6-scholarship-section.md +**Removed from production 2026-01-11** (commit `e8c1730`, "removed the scholarship stiff from +/about") — the section was built, then Naser had it deleted from the live `/about` page and its +language strings entirely. It does not exist in the current codebase. Kept here (rather than +deleted) for traceability only; do not re-implement without confirming with Naser first. + +Original intent, for history: As a website visitor I want to learn about Libra's scholarship +aspiration So that I understand their vision for supporting Palestinian arts and law students. +Full implementation history: docs/stories/story-16.6-scholarship-section.md ## Acceptance Criteria diff --git a/docs/tasks/statuses.md b/docs/tasks/statuses.md index 127dec3..1ea4124 100644 --- a/docs/tasks/statuses.md +++ b/docs/tasks/statuses.md @@ -120,4 +120,4 @@ | 16-3 | 16-3 Values Section | Done | | 16-4 | 16-4 Goals Section | Done | | 16-5 | 16-5 Legal Services Section | Done | -| 16-6 | 16-6 Scholarship Aspiration Section | Done | +| 16-6 | 16-6 Scholarship Aspiration Section (REMOVED from production 2026-01-11 — do not re-implement) | Done | diff --git a/docs/ux-design.md b/docs/ux-design.md index 7b53eba..a7b248c 100644 --- a/docs/ux-design.md +++ b/docs/ux-design.md @@ -107,10 +107,12 @@ for any new work — they are the most recent and match what Epic 12 shipped. Vision & Mission (three-fold: For Itself / For Society / For Diaspora, card layout) → Values (6 core values: Integrity, Justice, Knowledge, Women's Empowerment, Professionalism, Social Innovation) → Goals (7 goals, numbered/scannable) → Legal Services (grouped by category: - consultations, litigation, family law, business services) → Scholarship Aspiration section - (Libra Scholarship for Law and Palestinian Arts) → Footer. -- **Auth pages** (Epic 13 — login, forgot/reset password, 2FA challenge, confirm-password, email - verify): split-screen layout. Left panel: Dark Forest Green (`#2D3624`) background with the + consultations, litigation, family law, business services) → Footer. (A Scholarship Aspiration + section was built under this epic but removed from `/about` entirely on 2026-01-11 at Naser's + request — do not re-add without confirming; see `docs/tasks/16-6.md`.) +- **Auth pages** (Epic 13 — login, forgot/reset password, confirm-password, email verify): the + 2FA challenge page exists in code but is currently dormant — 2FA has been disabled in production + since 2026-01-17 (see root `CLAUDE.md` Authentication section). Split-screen layout. Left panel: Dark Forest Green (`#2D3624`) background with the LIBRA logo centered. Right panel: Warm Cream background with a subtle SVG botanical/geometric background pattern (low-opacity brand colors) behind the form. On mobile, only the form side shows, with the logo displayed above it. The language toggle's `light` variant was darkened