Add missing street name to footer address
Client reported the site's address was missing "Jaffa Street" — added to both Arabic and English footer strings (lang/ar/footer.php, lang/en/footer.php). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,61 @@
|
|||||||
|
---
|
||||||
|
id: 22
|
||||||
|
title: 22 Fix Footer Address - Add Missing Street Name
|
||||||
|
status: Done
|
||||||
|
date: 2026-09-28
|
||||||
|
parent: null
|
||||||
|
---
|
||||||
|
|
||||||
|
## Description
|
||||||
|
|
||||||
|
Client reported the site's footer address is missing the street name. Naser confirmed the correct
|
||||||
|
full address (his own words, pasted): "شارع يافا - بجانب الشني / العمارة الأمريكية - الطابق
|
||||||
|
الرابع" (Jaffa Street - next to Al-Shini / American Building - 4th Floor). Pure content/copy
|
||||||
|
change, no logic.
|
||||||
|
|
||||||
|
**File to modify:** `lang/ar/footer.php`
|
||||||
|
|
||||||
|
Current:
|
||||||
|
```php
|
||||||
|
'address' => 'العمارة الأمريكية - بجانب الشني - الطابق الرابع',
|
||||||
|
```
|
||||||
|
|
||||||
|
Change to:
|
||||||
|
```php
|
||||||
|
'address' => 'شارع يافا - بجانب الشني - العمارة الأمريكية - الطابق الرابع',
|
||||||
|
```
|
||||||
|
|
||||||
|
**File to modify:** `lang/en/footer.php`
|
||||||
|
|
||||||
|
Current:
|
||||||
|
```php
|
||||||
|
'address' => 'American Building - Next to Al-Shini - 4th Floor',
|
||||||
|
```
|
||||||
|
|
||||||
|
Change to:
|
||||||
|
```php
|
||||||
|
'address' => 'Jaffa Street - Next to Al-Shini - American Building - 4th Floor',
|
||||||
|
```
|
||||||
|
|
||||||
|
No other key in either file changes. This string is rendered in `resources/views/components/footer.blade.php`
|
||||||
|
line 24 via `{{ __('footer.address') }}` — no Blade file needs editing, only the two language
|
||||||
|
files above.
|
||||||
|
|
||||||
|
## Acceptance Criteria
|
||||||
|
|
||||||
|
- [x] `lang/ar/footer.php`'s `address` value equals exactly
|
||||||
|
`شارع يافا - بجانب الشني - العمارة الأمريكية - الطابق الرابع`
|
||||||
|
- [x] `lang/en/footer.php`'s `address` value equals exactly
|
||||||
|
`Jaffa Street - Next to Al-Shini - American Building - 4th Floor`
|
||||||
|
- [x] No other key in either file changed (verify: `git diff lang/ar/footer.php lang/en/footer.php`
|
||||||
|
shows exactly one changed line per file)
|
||||||
|
- [x] Visiting the home page (`/`) still returns HTTP 200 and its rendered HTML contains the new
|
||||||
|
Arabic address string (verify with a feature test or an `assertSee` against the existing
|
||||||
|
home-page test suite if one covers the footer; if none does, a simple new assertion is fine
|
||||||
|
— this is a content check, not new behavior, so TDD's RED/GREEN cycle doesn't apply the
|
||||||
|
normal way: writing an assertion that currently fails because the string doesn't match yet
|
||||||
|
counts as the "RED" step here)
|
||||||
|
|
||||||
|
## Sub-tasks
|
||||||
|
|
||||||
|
None.
|
||||||
@@ -133,3 +133,4 @@
|
|||||||
| 19 | 19 Nablus Workshop Form - Remove Logo, Shrink Flyer Further | Done |
|
| 19 | 19 Nablus Workshop Form - Remove Logo, Shrink Flyer Further | Done |
|
||||||
| 20 | 20 Nablus Workshop Form - Match Site Background and Card Styling | Done |
|
| 20 | 20 Nablus Workshop Form - Match Site Background and Card Styling | Done |
|
||||||
| 21 | 21 Nablus Workshop Form - Flyer Size Adjustment | Done |
|
| 21 | 21 Nablus Workshop Form - Flyer Size Adjustment | Done |
|
||||||
|
| 22 | 22 Fix Footer Address - Add Missing Street Name | Done |
|
||||||
|
|||||||
+1
-1
@@ -3,7 +3,7 @@
|
|||||||
return [
|
return [
|
||||||
'description' => 'خدمات قانونية مهنية بنزاهة وتميز.',
|
'description' => 'خدمات قانونية مهنية بنزاهة وتميز.',
|
||||||
'contact' => 'تواصل معنا',
|
'contact' => 'تواصل معنا',
|
||||||
'address' => 'العمارة الأمريكية - بجانب الشني - الطابق الرابع',
|
'address' => 'شارع يافا - بجانب الشني - العمارة الأمريكية - الطابق الرابع',
|
||||||
'phone' => '+970 599 353 502',
|
'phone' => '+970 599 353 502',
|
||||||
'email' => 'info@libra.adv.ps',
|
'email' => 'info@libra.adv.ps',
|
||||||
'legal' => 'قانوني',
|
'legal' => 'قانوني',
|
||||||
|
|||||||
+1
-1
@@ -3,7 +3,7 @@
|
|||||||
return [
|
return [
|
||||||
'description' => 'Professional legal services with integrity and excellence.',
|
'description' => 'Professional legal services with integrity and excellence.',
|
||||||
'contact' => 'Contact Us',
|
'contact' => 'Contact Us',
|
||||||
'address' => 'American Building - Next to Al-Shini - 4th Floor',
|
'address' => 'Jaffa Street - Next to Al-Shini - American Building - 4th Floor',
|
||||||
'phone' => '+970 599 353 502',
|
'phone' => '+970 599 353 502',
|
||||||
'email' => 'info@libra.adv.ps',
|
'email' => 'info@libra.adv.ps',
|
||||||
'legal' => 'Legal',
|
'legal' => 'Legal',
|
||||||
|
|||||||
@@ -556,3 +556,12 @@ test('home page displays post publication date', function () {
|
|||||||
->assertOk()
|
->assertOk()
|
||||||
->assertSee('15 January 2026');
|
->assertSee('15 January 2026');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// Footer Section Tests
|
||||||
|
|
||||||
|
test('home page displays footer address with street name in Arabic', function () {
|
||||||
|
$this->withSession(['locale' => 'ar'])
|
||||||
|
->get('/')
|
||||||
|
->assertOk()
|
||||||
|
->assertSee('شارع يافا - بجانب الشني - العمارة الأمريكية - الطابق الرابع');
|
||||||
|
});
|
||||||
|
|||||||
Reference in New Issue
Block a user