Naser Mansour
7d762902a2
max-h-40 (160px) was too small to read comfortably; bumped to max-h-56 (224px), between that and the original too-large 256px. Rebuilt frontend assets and confirmed the class compiled. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
69 lines
2.9 KiB
Markdown
69 lines
2.9 KiB
Markdown
---
|
|
id: 21
|
|
title: 21 Nablus Workshop Form - Flyer Size Adjustment
|
|
status: Done
|
|
date: 2026-09-28
|
|
parent: null
|
|
---
|
|
|
|
## Description
|
|
|
|
Follow-up to tasks 18/19. Naser says the flyer image is now a bit too small to read comfortably
|
|
(it was capped to `max-h-40`, 160px) — he wants it bumped up to a size that's still compact but
|
|
readable. Pure styling change, no logic involved.
|
|
|
|
**File to modify:** `resources/views/livewire/pages/forms/nablus-workshop.blade.php`
|
|
|
|
Current flyer image markup:
|
|
|
|
```blade
|
|
<img
|
|
src="{{ asset('images/workshop-nablus-flyer.jpeg') }}"
|
|
alt="ورشة متخصصة: القانون، التسويق الرقمي، وإدارة المتاجر الإلكترونية"
|
|
class="max-h-40 w-auto mx-auto rounded-lg shadow-[0_2px_8px_rgba(0,0,0,0.1)]"
|
|
/>
|
|
```
|
|
|
|
Change only the height cap, `max-h-40` → `max-h-56` (224px — roughly midway between the too-small
|
|
160px from task 19 and the too-large 256px from task 18). Nothing else in the class string
|
|
changes:
|
|
|
|
```blade
|
|
class="max-h-56 w-auto mx-auto rounded-lg shadow-[0_2px_8px_rgba(0,0,0,0.1)]"
|
|
```
|
|
|
|
`max-h-56` is a standard Tailwind spacing-scale utility (14rem), same family as the `max-h-40`/
|
|
`max-h-64` already used in this file's history, so it will compile the same way once the frontend
|
|
build runs (see step below — required, do not skip).
|
|
|
|
**Required build step:** after making the edit, run `npm run build` (node/npm are only reachable
|
|
via `source ~/.nvm/nvm.sh && nvm use v24.20.0` in this environment — not on the default PATH) and
|
|
grep the freshly generated `public/build/assets/*.css` file for `max-h-56` to confirm it compiled.
|
|
Tasks 18/19 shipped a class that silently never took effect because nobody rebuilt the stale
|
|
`public/build` bundle — do not repeat that.
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [x] The flyer `<img>` tag's class attribute in
|
|
`resources/views/livewire/pages/forms/nablus-workshop.blade.php` contains `max-h-56` and
|
|
does not contain `max-h-40` or `max-h-64`
|
|
- [x] `npm run build` was run after the edit, and `max-h-56` is confirmed present (via grep) in
|
|
the newly generated `public/build/assets/*.css` — state the exact filename and grep result
|
|
in the completion report
|
|
- [x] Visiting `/forms/nablus-workshop` still returns HTTP 200
|
|
- [x] The existing test suite for this page (`tests/Feature/Public/NablusWorkshopRegistrationTest.php`)
|
|
still passes unchanged
|
|
|
|
## QA Verification (2026-09-28)
|
|
|
|
- Class attribute confirmed: `class="max-h-56 w-auto mx-auto rounded-lg shadow-[0_2px_8px_rgba(0,0,0,0.1)]"`
|
|
— no `max-h-40`/`max-h-64` present.
|
|
- Grepped current `public/build/assets/app-XIQ2Iam8.css` fresh (not trusting the report's
|
|
filename) — file confirmed still present with that name, `max-h-56` found in it.
|
|
- `curl http://127.0.0.1:8971/forms/nablus-workshop` → HTTP 200.
|
|
- `php artisan test tests/Feature/Public/NablusWorkshopRegistrationTest.php` → 7 passed (26 assertions).
|
|
|
|
## Sub-tasks
|
|
|
|
None.
|